[PATCH] D88190: C API: functions to get mask of a ShuffleVector

[Craig Disselkoen via Phabricator via llvm-commits]

cdisselkoen added inline comments.


================
Comment at: llvm/tools/llvm-c-test/echo.cpp:812
+              "ShuffleVector: Expected no more than 8 mask elements");
+        LLVMValueRef MaskElts[8];
+        for (unsigned i = 0; i < NumMaskElts; i++) {
----------------
efriedma wrote:
> cdisselkoen wrote:
> > cdisselkoen wrote:
> > > efriedma wrote:
> > > > Any particular reason you aren't using a SmallVector here?
> > > I guess it was just because conceptually in my mind this is C code and not C++ code (it consumes the C API).  Happy to use SmallVector if you prefer
> > Updated to use SmallVector
> Did you mean to use push_back?
Uh, yes I did, whoops.  Weird, I thought I ran tests locally but I must have not done that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88190/new/

https://reviews.llvm.org/D88190