[PATCH] D88268: [lld-macho] Ignore a few more undocumented flags

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added subscribers: llvm-commits, dang.
Herald added a project: LLVM.
int3 requested review of this revision.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88268

Files:
  lld/MachO/Options.td
  lld/test/MachO/silent-ignore.test


Index: lld/test/MachO/silent-ignore.test
===================================================================
--- lld/test/MachO/silent-ignore.test
+++ lld/test/MachO/silent-ignore.test
@@ -5,6 +5,9 @@
 RUN:   -lto_library /lib/foo \
 RUN:   -macosx_version_min 0 \
 RUN:   -dependency_info /path/to/dependency_info.dat \
-RUN:   -mllvm -time-passes
+RUN:   -mllvm -time-passes \
+RUN:   -objc_abi_version 2 \
+RUN:   -ios_simulator_version_min 9.0.0 \
+RUN:   -sdk_version 13.2
 RUN: not %lld -v --not-an-ignored-argument 2>&1 | FileCheck %s
 CHECK: error: unknown argument: --not-an-ignored-argument
Index: lld/MachO/Options.td
===================================================================
--- lld/MachO/Options.td
+++ lld/MachO/Options.td
@@ -188,6 +188,10 @@
      MetaVarName<"<platform> <min_version> <sdk_version>">,
      HelpText<"Platform (e.g., macos, ios, tvos, watchos, bridgeos, mac-catalyst, ios-sim, tvos-sim, watchos-sim, driverkit) and version numbers">,
      Group<grp_opts>;
+def sdk_version : Separate<["-"], "sdk_version">,
+     HelpText<"This option is undocumented in ld64">,
+     Flags<[HelpHidden]>,
+     Group<grp_opts>;
 def macos_version_min : Separate<["-"], "macos_version_min">,
      MetaVarName<"<version>">,
      HelpText<"Oldest macOS version for which linked output is useable">,
@@ -204,6 +208,11 @@
      HelpText<"Oldest iOS version for which linked output is useable">,
      Flags<[HelpHidden]>,
      Group<grp_opts>;
+def ios_simulator_version_min : Separate<["-"], "ios_simulator_version_min">,
+     MetaVarName<"<version>">,
+     HelpText<"Oldest iOS simulator version for which linked output is useable">,
+     Flags<[HelpHidden]>,
+     Group<grp_opts>;
 def iphoneos_version_min : Separate<["-"], "iphoneos_version_min">,
      MetaVarName<"<version>">,
      Alias<ios_version_min>,
@@ -1212,7 +1221,7 @@
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,
      Group<grp_undocumented>;
-def objc_abi_version : Flag<["-"], "objc_abi_version">,
+def objc_abi_version : Separate<["-"], "objc_abi_version">,
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,
      Group<grp_undocumented>;
@@ -1228,10 +1237,6 @@
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,
      Group<grp_undocumented>;
-def sdk_version : Flag<["-"], "sdk_version">,
-     HelpText<"This option is undocumented in ld64">,
-     Flags<[HelpHidden]>,
-     Group<grp_undocumented>;
 def simulator_support : Flag<["-"], "simulator_support">,
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88268.294194.patch
Type: text/x-patch
Size: 2649 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200924/e35f7106/attachment.bin>