[PATCH] D88262: [WebAssembly] Make SjLj lowering globals thread-local

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Awesome thanks!



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:322
+                              GlobalVariable::ExternalLinkage, nullptr, Name,
+                              nullptr, GlobalValue::LocalExecTLSModel);
+  }));
----------------
I'm surprised this is the cleanest way to do make the global as TLS...  I still find lambdas a little harder to parse that straight line code.      It kind of makes me what to write a little named functions called `makeTLSGlobal` to make this easier tfor me to read, but maybe thats just me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88262/new/

https://reviews.llvm.org/D88262