[PATCH] D87199: [lld-macho] Implement support for PIC

[Jez Ng via Phabricator via llvm-commits]

int3 marked 2 inline comments as done.
int3 added inline comments.


================
Comment at: lld/MachO/Writer.cpp:341-343
   for (InputSection *isec : inputSections) {
     for (Reloc &r : isec->relocs) {
       if (auto *s = r.referent.dyn_cast<lld::macho::Symbol *>()) {
----------------
gkm wrote:
> This is better: nothing in the `relocs` loop pertains to `__compact_unwind` so we can skip it at the top.
good point. I've gone with this option, plus added a TODO so we revisit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199