[PATCH] D85649: [AArch64] PAC/BTI code generation for LLVM generated functions

Thu Sep 24 12:16:15 PDT 2020

nickdesaulniers accepted this revision.
nickdesaulniers added a subscriber: momchil.velikov.
nickdesaulniers added a comment.

Thank you @momchil.velikov for considering the case for LTO, and testing C+asm linkage.

> actually when compiling with BTI the "-Wl,-fatal-warnings, -Wl,-z,force-bti" could be added to the linker flags to catch these things, I will send a patch to the kernel mailing list.

SGTM, I'd be happy to help test it.

================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:593-594

+  if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::aarch64_32 ||
+      Arch == llvm::Triple::aarch64_be) {
+    getModule().addModuleFlag(llvm::Module::Error,
----------------
I was wondering if `Arch.isAArch64()` would be more concise, but curiously it does not contain `aarch64_32` `ArchType`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85649/new/

https://reviews.llvm.org/D85649