[PATCH] D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS

[Michael Pique via Phabricator via llvm-commits]

Michael_Pique created this revision.
Michael_Pique added a reviewer: jdoerfert.
Michael_Pique added a project: OpenMP.
Herald added subscribers: llvm-commits, danielkiss, luismarques, s.egerton, lenary, PkmX, atanasyan, simoncook, kristof.beyls, arichardson, sdardis.
Herald added a project: LLVM.
Michael_Pique requested review of this revision.
Herald added a subscriber: sstefan1.

Added macro calls to adjust external reference for Darwin/AARCH64 link compatibility. Deleted ".size" directive not accepted by llvm/Clang arm64 assembler.  I do not know whether the .size directive is accepted, or required, by the PPC64, MIPS64, or RISCV64 assemblers as I have no way to test on those.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88252

Files:
  z_Linux_asm.S


Index: z_Linux_asm.S
===================================================================
--- z_Linux_asm.S
+++ z_Linux_asm.S
@@ -1746,10 +1746,9 @@
     .comm .gomp_critical_user_,32,8
     .data
     .align 8
-    .global __kmp_unnamed_critical_addr
-__kmp_unnamed_critical_addr:
+    .global KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr)
+KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr):
     .8byte .gomp_critical_user_
-    .size __kmp_unnamed_critical_addr,8
 #endif /* KMP_ARCH_PPC64 || KMP_ARCH_AARCH64 || KMP_ARCH_MIPS64 ||
           KMP_ARCH_RISCV64 */
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88252.294122.patch
Type: text/x-patch
Size: 573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200924/cd41c3d0/attachment.bin>