[PATCH] D88190: C API: functions to get mask of a ShuffleVector

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 11:51:42 PDT 2020


efriedma added a reviewer: hans.
efriedma added a comment.

These changes all make sense, I think.



================
Comment at: llvm/tools/llvm-c-test/echo.cpp:812
+              "ShuffleVector: Expected no more than 8 mask elements");
+        LLVMValueRef MaskElts[8];
+        for (unsigned i = 0; i < NumMaskElts; i++) {
----------------
Any particular reason you aren't using a SmallVector here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88190/new/

https://reviews.llvm.org/D88190



More information about the llvm-commits mailing list