[PATCH] D88244: [AMDGPU] Split R600 and GCN bfi patterns

Thu Sep 24 10:05:35 PDT 2020

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM, I've been meaning to do this. I do think some of these should be moved to combines and are missing hasOneUse checks though

================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:1594-1621
+def : AMDGPUPat <
+  (fcopysign f32:$src0, f32:$src1),
+  (V_BFI_B32 (S_MOV_B32 (i32 0x7fffffff)), $src0, $src1)
+>;
+
+def : AMDGPUPat <
+  (fcopysign f32:$src0, f64:$src1),
----------------
Maybe add a comment for the fcopysign cases that we don't want to import them for globalisel

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88244/new/

https://reviews.llvm.org/D88244