[PATCH] D88221: [flang][OpenMP] Upstream OpenMP Parallel construct codegen support

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

This is not "codegen support" is it? That sounds like "we now support codegen of X". Maybe: "Fix XXX codegen insertion point placement"?

Also "Code inside a Parallel operation region is lowered into FIR Dialect" seem to not capture this, this is just the "overall phase" in which the code is executed, right?
I mean, what happens here is the insert point is moved from something to something. Can we add a sentence that says why the new location is better? Maybe add a test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88221/new/

https://reviews.llvm.org/D88221