[PATCH] D88165: IR: Have byref imply dereferenceable

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 06:57:47 PDT 2020


arsenm closed this revision.
arsenm added a comment.

dc08185ca797a3bcd7721a0d55db876a6cc4de10 <https://reviews.llvm.org/rGdc08185ca797a3bcd7721a0d55db876a6cc4de10>



================
Comment at: llvm/test/Transforms/Attributor/value-simplify.ll:355
+; IS__CGSCC____-SAME: () [[ATTR1]] {
+; IS__CGSCC____-NEXT:    unreachable
 ;
----------------
arsenm wrote:
> jdoerfert wrote:
> > ups. Could you maybe repair the tests to avoid UB here?
> I'm not sure what this is trying to test exactly. What argument should this pass instead?
Just forwarding an argument seems to have worked


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88165/new/

https://reviews.llvm.org/D88165



More information about the llvm-commits mailing list