[llvm] f5314d1 - [Support] On Unix, let the CrashRecoveryContext return the signal code
Alexandre Ganea via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 24 06:08:42 PDT 2020
It seems that on Linux signal.h is implicitly imported:
. /mnt/f/llvm-project/llvm/utils/unittest/googletest/include/gtest/gtest.h
.. /mnt/f/llvm-project/llvm/utils/unittest/googletest/include/gtest/internal/gtest-internal.h
... /usr/include/x86_64-linux-gnu/sys/wait.h
.... /usr/include/signal.h
I've commited the following fix: a6a6ccfc4c8b348d6d534657e16bb7504b9f2888
If it still fails, I'll revert.
Thanks for the heads up!
-----Message d'origine-----
De : Florian Hahn <florian_hahn at apple.com>
Envoyé : September 24, 2020 8:57 AM
À : Florian Hahn <florian_hahn at apple.com>
Cc : Alexandre Ganea <alexandre.ganea at ubisoft.com>; llvm-commits at lists.llvm.org
Objet : Re: [llvm] f5314d1 - [Support] On Unix, let the CrashRecoveryContext return the signal code
> On Sep 24, 2020, at 13:38, Florian Hahn via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
>
>
>> On Sep 24, 2020, at 13:33, Alexandre Ganea <alexandre.ganea at ubisoft.com> wrote:
>>
>> Thanks Florian! Sorry I'm not a Mac expert, is it because the API isn't there, or because of a missing include?
>
>
> I am not sure. Where comes raise from on Linux? It appears to be present in signal.h on macOS, but that appears not included in the file?
>
>
This also causes some bots to fail, e.g. http://green.lab.llvm.org/green/job/clang-stage1-RA/14828/console
More information about the llvm-commits
mailing list