[PATCH] D88219: [flang][driver] Remove unnecessary includes in the unittest
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 24 05:21:17 PDT 2020
awarzynski added inline comments.
================
Comment at: flang/unittests/Frontend/CompilerInstanceTest.cpp:23
std::string diagnosticOutput;
llvm::raw_string_ostream diagnosticsOS(diagnosticOutput);
auto diagPrinter = std::make_unique<clang::TextDiagnosticPrinter>(
----------------
DavidTruby wrote:
> CarolineConcatto wrote:
> > Don't we need to include #include "llvm/Support/raw_ostream.h"?
> This builds for me so I assume it's transitively included by one of the other includes. Probably "flang/Frontend/CompilerInstance.h"?
My bad - I searched the file for `raw_ostream`, but I should've searched for `raw_string_ostream` instead, sorry! `raw_ostream.h` is included via `TextDiagnosticPrinter.h`, so the test will continue to work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88219/new/
https://reviews.llvm.org/D88219
More information about the llvm-commits
mailing list