[PATCH] D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 01:01:48 PDT 2020


jhenderson accepted this revision.
jhenderson added subscribers: ikudrin, dblaikie.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM! Nice work! (Also cc'ed both @ikudrin and @dblaikie who regularly work in the DWARF area).



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/verify_die_ranges.yaml:1
+# RUN: yaml2obj %s | not llvm-dwarfdump -verify - | FileCheck %s
+
----------------
Whilst you're modifying this test, I'd split this up into separate yaml2obj and llvm-dwarfdump commands (i.e. no piping between the two) to make it easier to debug the test in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88200/new/

https://reviews.llvm.org/D88200



More information about the llvm-commits mailing list