[PATCH] D87674: [AMDGPU] Insert waitcnt after returning from call

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 00:22:03 PDT 2020


nhaehnle added a comment.

In D87674#2290548 <https://reviews.llvm.org/D87674#2290548>, @madhur13490 wrote:

> The revert also highlights the problem that we don't have representative test in llvm/test :(

Don't we? Isn't the problem rather that a lit test alone isn't really authoritative on whether the generated code is correct? There are cases where it's easy to convince yourself that a change in codegen is correct even though it isn't, if you're only staring at the assembly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87674/new/

https://reviews.llvm.org/D87674



More information about the llvm-commits mailing list