[PATCH] D87199: [lld-macho] Implement support for PIC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 23:31:41 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:165
+  llvm::sort(locations, [](const Location &a, const Location &b) {
+    return a.getVA() < b.getVA();
+  });
----------------
If there are empty sections, there may be stability concerns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199



More information about the llvm-commits mailing list