[PATCH] D88192: Add support for setting the path to llvm-symbolizer through an environment variable

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Support/Signals.cpp:124
+  if (getenv(LLVMSymbolizerPathEnv))
+    LLVMSymbolizerPathOrErr =
+        sys::findProgramByName(getenv(LLVMSymbolizerPathEnv));
----------------
And perhaps you want to add a pair of braces because ...

You wrote https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements :)
```
// Use braces for the `if` block to keep it uniform with the else block.
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88192/new/

https://reviews.llvm.org/D88192