[PATCH] D88048: [dwarfdump] Add verifier check to find DIEs with DW_CHILDREN_yes but without children.

Wed Sep 23 22:16:11 PDT 2020

JDevlieghere added a comment.

In D88048#2286776 <https://reviews.llvm.org/D88048#2286776>, @Higuoxing wrote:

> In D88048#2286589 <https://reviews.llvm.org/D88048#2286589>, @dblaikie wrote:
>
>> maybe slightly long test case - could do this with the CU DIE itself? (perhaps a case where hand-crafted/substantially hand-modified assembly is OK, because it can be made /so/ simple - or maybe yaml2obj dwarf support is adequate for this use case?)
>
> Hi, currently, `obj2yaml` doesn't work properly when dumping the .debug_abbrev/__debug_abbrev section. We might not be able to get the correct output when there are multiple DIEs in one abbrev table. D87179 <https://reviews.llvm.org/D87179> has fixed it but hasn't been landed yet. I've created one test case for this patch. Hope it works :-)

(I forgot to submit the comment before landing this)

Awesome, thanks a lot, that's a great test case! :-)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88048/new/

https://reviews.llvm.org/D88048