[PATCH] D87497: [llvm-objcopy][MachO] Fix --add-section

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/add-section-32.test:5
+# RUN: yaml2obj %s -o %t
+# RUN: echo -n abcdefg > %t.data
+
----------------
jhenderson wrote:
> This is probably absolutely fine, but are you aware of the new `split-file` tool? It allows writing multiple inputs inline within the same file, for example:
> 
> ```
> ## Split %s into separate files, located in new %t directory.
> # RUN: split-file %s %t
> <test logic>
> 
> ## NB: the new line at the end of data.bin's contents will be included.
> #--- data.bin
> abcdefg
> #--- input.yaml
> --- !mach-o
> ...
> ```
> 
> Not sure there's necessarily any advantage to using it here, since the input is simple.
thanks, will keep this in mind


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87497/new/

https://reviews.llvm.org/D87497