[PATCH] D86909: [lld-macho] Initial support for common symbols

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:421
+// any CommonSymbols.
+static void replaceCommonSymbols() {
+  for (macho::Symbol *sym : symtab->getSymbols()) {
----------------
gkm wrote:
> Nit, bordering on Super Nit:
> Say more about the nature of this replacement
>  - `replaceCommonSymbolsWithDefinedSymbols` ?
>  - `defineCommonSymbols` ?
>  - `upgradeCommonSymbolsToDefined` ?
I agree the name could be more informative, but this name is taken from a similar function in lld-elf, and I'd prefer to match them where possible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86909/new/

https://reviews.llvm.org/D86909