[PATCH] D85670: [Instruction] Add updateLocationAfterHoist helper

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Seems good to me - minor tidy up might be possible in the unit test.



================
Comment at: llvm/unittests/IR/InstructionsTest.cpp:1350
+
+    EXPECT_FALSE(bool(I1->getDebugLoc()));
+    I1->dropLocation();
----------------
Maybe these should be `EXPECT_EQ(I1->getDebugLoc(), DebugLoc());`? Would that work? Would hopefully give better failure messages by printing the values when the expect fails.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85670/new/

https://reviews.llvm.org/D85670