[PATCH] D88060: [GISel]: Few InsertVecElt combines

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2453
+      return *UndefReg;
+    Builder.setInstr(MI);
+    UndefReg = Builder.buildUndef(DstTy.getScalarType()).getReg(0);
----------------
arsenm wrote:
> aditya_nandakumar wrote:
> > arsenm wrote:
> > > I don't think you need to reset the insert point here
> > I'm not resetting. I'm making sure it's set correctly (MI) so I can insert IMPLICIT_DEFs.
> Oh, actually this is modifying the MIR in the match function which seems like a problem. Can you defer this to apply?
Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88060/new/

https://reviews.llvm.org/D88060