[PATCH] D88176: Explicitly specify CMAKE_AR in WinMsvc.cmake
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 23 15:47:43 PDT 2020
smeenai accepted this revision.
smeenai added a comment.
LGTM
https://gitlab.kitware.com/cmake/cmake/-/commit/55196a1440e26917d40e6a7a3eb8d9fb323fa657 is the relevant CMake change, and I believe we need to add logic to find llvm-lib. I'll play with that.
Could you update the commit message? (If you updated it locally, you'll need to run `arc diff --verbatim` to sync it to Phabricator.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88176/new/
https://reviews.llvm.org/D88176
More information about the llvm-commits
mailing list