[PATCH] D87178: [lld-macho] Emit indirect symbol table

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/OutputSection.h:66-67
   uint32_t flags = 0;
+  uint32_t reserved1 = 0;
+  uint32_t reserved2 = 0;
 
----------------
gkm wrote:
> Semantically blank names are beyond our reach in `struct section_64`, but `class OutputSection` is ours and we have the freedom to grant meaningful names. In `writeTo()` the assignments from members of `OutputSection` to `section_64` will make it clear how the meaningful names map onto the meaningless names.
It's not clear to me that `reserved1` is *only* used to point to the indirect symbol table. Its semantics might be section-type-specific. That's why I didn't call it `indirectSymtabOffset` or something


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87178/new/

https://reviews.llvm.org/D87178