[PATCH] D84287: [SelectionDAG][GISel] Make LegalizeDAG lower FNEG using integer ops.

Wed Sep 23 14:08:38 PDT 2020

efriedma added inline comments.

================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-fneg.mir:2
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -O0 -run-pass=legalizer %s -o - | FileCheck %s

----------------
arsenm wrote:
> RKSimon wrote:
> > efriedma wrote:
> > > RKSimon wrote:
> > > > Worth adding a f80 case as well?
> > > f80 currently isn't supported by GlobalISel.
> > ok - I was mainly interested in seeing what happened with a non-legal integer type - not a big issue though
> It doesn't work end to end, but it should work here if you use an 80 bit value
I wrote a test, and got "LLVM ERROR: unable to legalize instruction: %1:_(s80) = G_XOR %0:_, %2:_ (in function: test_fneg_f80)".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84287/new/

https://reviews.llvm.org/D84287