[PATCH] D87835: [APFloat] prevent NaN morphing into Inf on conversion (PR43907)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 23 13:23:57 PDT 2020
spatel added a comment.
In D87835#2290688 <https://reviews.llvm.org/D87835#2290688>, @rjmccall wrote:
> Okay. If we've decided that preserving an sNaN is the best thing to do, as opposed to making it quiet but setting invalid-op, then this looks good to me. But I would be happier if we just made that decision now (what better time?) and then didn't need the TODO.
I don't have an opinion/experience on the sNaN details, so I'm just going on what's been posted in this review.
@scanon / @efriedma - is this good (enough)?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87835/new/
https://reviews.llvm.org/D87835
More information about the llvm-commits
mailing list