[PATCH] D87929: [lld-macho] Support -weak_lx, -weak_library, -weak_framework

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:619-627
+    case OPT_l:
+    case OPT_weak_l: {
       StringRef name = arg->getValue();
       if (Optional<std::string> path = findLibrary(name)) {
         addFile(*path);
+        if (opt.getID() == OPT_weak_l)
+          weakImportPaths.insert(saver.save(*path));
----------------
gkm wrote:
> How about something like this ...
> Also change `addFile()` to return its newly-constructed `InputFile*`
that was cleaner than I'd anticipated it being. thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87929/new/

https://reviews.llvm.org/D87929