[PATCH] D88060: [GISel]: Few InsertVecElt combines
Aditya Nandakumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 23 09:54:50 PDT 2020
aditya_nandakumar marked 2 inline comments as done.
aditya_nandakumar added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2432
+
+ // Make sure we have correct no of elements.
+ if (Inserts.size() != NumElts)
----------------
arsenm wrote:
> s/no/number. Couldn't this add undefs for the missing elements?
I was planning on handling the duplicate as well as missing cases in a follow up commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88060/new/
https://reviews.llvm.org/D88060
More information about the llvm-commits
mailing list