[PATCH] D88163: [flang][msvc] Avoid ctor initializer list population of vector. NFC.

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 09:52:33 PDT 2020


klausler added inline comments.


================
Comment at: flang/include/flang/Evaluate/constant.h:101
+  ConstantBase(ELEMENT &&x, Result res = Result{}) : result_{res} {
+    values_.push_back(std::move(x));
+  }
----------------
This change will restrict this constructor to work only with scalar items, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88163/new/

https://reviews.llvm.org/D88163



More information about the llvm-commits mailing list