[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:3165
 
+static bool isEltOfVectorTy(ASTContext &Context, CallExpr *Call, Sema &S,
+                            QualType VectorEltTy, QualType EltTy) {
----------------
I think this should actually take a vector type and a scalar type. Then check that the scalar type is the same as the element type of the vector. The way this is implemented, a more apt name would be something like `checkSameTypes()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83500/new/

https://reviews.llvm.org/D83500