[PATCH] D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/SystemZ/huge-immediates.ll:1
+; RUN: opt < %s -cost-model -analyze -mtriple=systemz-unknown -mcpu=z13
+;
----------------
jonpa wrote:
> RKSimon wrote:
> > Might be worth adding a FileCheck - you can use update_analyze_test_checks.py to handle it.
> The reason that I left that out is that the cost values for these i72 instructions do not quite make sense. A comparison with an i72 immediate gets the cost of '1', which is certainly too little.
> 
> However, we do not care about those costs, so it makes most sense to me then to not check for their values either.
> 
> Is it then ok to leave it as is, or is it better for some reason to auto-generate the full test with the CHECKs?
yes its ok to leave them out if you don't think they're useful - sometimes you learn something "interesting" by including them (especially for non-legal types) 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88082/new/

https://reviews.llvm.org/D88082