[PATCH] D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 02:08:50 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:638
+##                                                       ^--- file length (ULEB128) 0x1234
+# EXTLEN-NEXT: 0x00000020 00b42401{{ }}
+##                        ^-                                  DW_LNS_extended_op
----------------
I think you need more than one space in the pattern. Otherwise this will still match:
`00b42401 11223344` which would be the output with data appearing after the thing you want to check.

Thinking about it, I don't think `{{  }}` (two spaces) will work without FileCheck's --strict-whitespace. You might just be better off adding the extra bit at the end of the line for this line only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88136/new/

https://reviews.llvm.org/D88136



More information about the llvm-commits mailing list