[PATCH] D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results

Wed Sep 23 01:46:47 PDT 2020

rengolin added a comment.

In D57953#2289359 <https://reviews.llvm.org/D57953#2289359>, @masakiarai wrote:

> I implemented this as a new optimization pass, so I will upload it.
> I'm thinking of getting a new Phabricator review number and linking it from this comment section.
> Is this a reasonable procedure?

If the implementation is completely different, they I guess it would make sense to start fresh. If you do, please close this one with a comment, pointing to the new review.

You should also refer back to this review, in the new one, in case people want to read the previous context.

Also, copy all people that interacted with this review and mention it's a rework, so they continue reviewing the "same" work.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57953/new/

https://reviews.llvm.org/D57953