[PATCH] D88089: [llvm-readelf/obj] - Fix extended section symbol indices printed in warnings for MIPS GOT/PLT entries.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, aside from one question.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6778-6779
       std::string SymName = this->dumper()->getFullSymbolName(
-          Sym, Sym - &Parser.getGotDynSyms()[0],
-          this->dumper()->getDynamicStringTable(), true);
       W.printNumber("Name", SymName, Sym->st_name);
----------------
I don't know MIPS at all. Is `getGotDynSyms()` equivalent to `dynamic_symbols()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88089/new/

https://reviews.llvm.org/D88089