[PATCH] D87667: [Support/Path] Add path::is_absolute_gnu

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

A couple of remaining comment suggestions, otherwise I think this looks good.



================
Comment at: llvm/include/llvm/Support/Path.h:454
 ///
+/// C++17 rules are:
+/// 1) POSIX style paths with nonempty root directory are absolute.
----------------
It might be worth adding the suggested quote, taken from https://en.cppreference.com/w/cpp/filesystem/path/is_absrel prior to the list.


================
Comment at: llvm/lib/Support/Path.cpp:690
+
+  // Handle '/' which should be true regardless Windows or POSIX.
+  // Handle '\\' on Windows.
----------------
jhenderson wrote:
> 
You can delete "on GNU", since it's implied (we're in `is_absolute_gnu` already).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87667/new/

https://reviews.llvm.org/D87667