[PATCH] D87596: [Coroutines] Reuse storage for local variables with non-overlapping lifetimes

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 23:45:37 PDT 2020


ChuanqiXu added a comment.

In D87596#2287989 <https://reviews.llvm.org/D87596#2287989>, @lxfind wrote:

> Overall LGTM. Thank you for addressing the feedback!
> One last thing, the optimization level code can be further simplified. Since you are obtaining the `OptLevel` from the `PassManagerBuilder`, which is an integer. I feel it would be easier if you just stick with an integer optlevel instead of converting it to `OptimizationLevel`. The reason `OptimizationLevel` exists is to be able to model both OptLevel and SizeLevel at the same time, but here you don't really care about the SizeLevel. So I would suggest just use an int for it and save all the trouble converting.

Thanks for your suggestion!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87596/new/

https://reviews.llvm.org/D87596



More information about the llvm-commits mailing list