[PATCH] D87817: [LICM][Coroutine] Don't sink stores to coroutine suspend point.

Tue Sep 22 23:27:19 PDT 2020

junparser added a comment.

In D87817#2278816 <https://reviews.llvm.org/D87817#2278816>, @junparser wrote:

> In D87817#2278717 <https://reviews.llvm.org/D87817#2278717>, @junparser wrote:
>
>> We try to find an general solution to handle some conservative  & mismatch analysis in transformations caused by the change of cfg with coro.suspend intrinsic.  However afaik,  it seems quiet difficult to deal this without change framework fo coroutine. 
>> This patch just fixes the known issue, it may happens in other passes, FYI.
>
> one of the idea is that we do not generate default case for switch instruction of coro.suspend intrinsic. Instead, we find fall through coro.end for coro.suspend directly in corosplit pass. The only uncertain thing is whether  fall through coro.end is moved by passes which may change the semantic.

@lxfind, what do you think about this idea?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87817/new/

https://reviews.llvm.org/D87817