[PATCH] D88107: [NewPM] Add callbacks to PassBuilder to run before/after parsing a pass

[Yuanfang Chen via Phabricator via llvm-commits]

ychen accepted this revision.
ychen added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.



================
Comment at: llvm/unittests/IR/PassBuilderCallbacksTest.cpp:1189
+    int C = Counter++;
+    if (I == 0)
+      I = C;
----------------
aeubanks wrote:
> ychen wrote:
> > assert (I==0); ?
> The CounterPasses added in the callbacks will run multiple times since these also run on implicitly created PassManagers, and I only want to catch very first time one runs.
I see. Could you please add a comment about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88107/new/

https://reviews.llvm.org/D88107