[PATCH] D87811: [CodeGen] emit CG profile for COFF object file

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 14:43:24 PDT 2020


zequanwu added inline comments.


================
Comment at: llvm/lib/Target/TargetLoweringObjectFile.cpp:164
+    auto *V = cast<ValueAsMetadata>(MDO);
+    const Function *F = cast<Function>(V->getValue());
+    return TM->getSymbol(F);
----------------
rnk wrote:
> I had to revert this change in rG90242caca2074dab5a9b76e5bc36d9fafd2179a7. I think the fix might be to return null if the call graph edge target is marked dllimport here.
I was thinking about a discussion in https://reviews.llvm.org/D81775?id=270540#inline-751699, which might be the cause. I was trying to do the same as ELF. Not sure if that's the cause.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87811/new/

https://reviews.llvm.org/D87811



More information about the llvm-commits mailing list