[PATCH] D87909: [lld-macho] Support absolute symbols
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 22 12:21:20 PDT 2020
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/MachO/Symbols.cpp:18-20
+ if (isAbsolute())
+ return false;
+ return isThreadLocalVariables(isec->flags);
----------------
If you don't anticipate the logic here getting more complex, we could just do a one-liner (and potentially move it back to the header).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87909/new/
https://reviews.llvm.org/D87909
More information about the llvm-commits
mailing list