[PATCH] D87960: [lld-macho] Always include custom syslibroot when running tests

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added subscribers: MaskRay, smeenai.
smeenai requested changes to this revision.
smeenai added a comment.
This revision now requires changes to proceed.

The test cleanups are really nice, but I'm not a fan of coding this sort of test-specific behavior (especially the path) into LLD itself :/ (I know we have some precedent with `LLD_IN_TEST`, but that's only used in `canExitEarly` and it's a pretty minor behavior change.)

Given the previous objection to substitutions though, this might be the best solution. I think I'd feel better about it if the environment variable just contained the syslibroot path directly, because then the path (which is test-specific knowledge) is fully contained in the test configs.

Also adding @MaskRay in case he has any thoughts on substitutions vs. environment variables.

(Requesting changes to put back in your queue.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87960/new/

https://reviews.llvm.org/D87960