[PATCH] D88110: [flang][driver] Add missing dependency in CMake files

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski created this revision.
Herald added subscribers: llvm-commits, mgorny.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
awarzynski requested review of this revision.

The Flang driver depends on libclangBasic. This means, among other
things, that some of the tablegen files (e.g. diagnostic definitions)
need to be generated before various libclangBasic header files can be
included (e.g. DiagnosticIDs.h). If we are lucky, libclangBasic is
indeed built before various flang driver libraries that depend on it
are. This patch makes sure that this is deterministic - i.e.
libclangBasic is built before the Flang driver libraries are.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88110

Files:
  flang/lib/Frontend/CMakeLists.txt
  flang/lib/FrontendTool/CMakeLists.txt


Index: flang/lib/FrontendTool/CMakeLists.txt
===================================================================
--- flang/lib/FrontendTool/CMakeLists.txt
+++ flang/lib/FrontendTool/CMakeLists.txt
@@ -1,6 +1,9 @@
 add_flang_library(flangFrontendTool
   ExecuteCompilerInvocation.cpp
 
+  DEPENDS
+  clangBasic
+
   LINK_LIBS
   clangBasic
   clangDriver
Index: flang/lib/Frontend/CMakeLists.txt
===================================================================
--- flang/lib/Frontend/CMakeLists.txt
+++ flang/lib/Frontend/CMakeLists.txt
@@ -3,6 +3,9 @@
   CompilerInvocation.cpp
   FrontendOptions.cpp
 
+  DEPENDS
+  clangBasic
+
   LINK_LIBS
   clangBasic
   clangDriver


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88110.293539.patch
Type: text/x-patch
Size: 675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200922/b7edccd6/attachment.bin>