[PATCH] D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp:718
+    // a DW_OP_entry_value.
+    if (cast<DILocalVariable>(Var)->isParameter())
+      EntryValue =
----------------
Orlando wrote:
> I think this we should only be doing this for immutable parameters (and mutable parameters which are never assigned to), right?
> 
> I.e. the entry_value of a parameter register is only a valid location for a parameter variable if that variable is never assigned another value.
We are expressing the modification in terms of its entry value here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87357/new/

https://reviews.llvm.org/D87357