[PATCH] D57779: [SLP] Add support for throttling.

[Dinar Temirbulatov via Phabricator via llvm-commits]

dtemirbulatov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3311-3312
+        TreeEntry *UserTE = getTreeEntry(U);
+        if (!UserTE || UserTE->State != TreeEntry::ProposedToGather)
+          continue;
+        // Ignore users in the user ignore list.
----------------
ABataev wrote:
> Could you compare it with a similar code in BoUpSLP::buildTree? Looks like you still missed some cases for user ignoring.
I think those ignoring cases are related to the fact that we are doing full vectorization at BoUpSLP::buildTree and we can avoid extracting for in-tree users. And here we have to extract to each user of once proposed to vectorized value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779