[PATCH] D88081: [AMDGPU] Move WQM Pass after MI Scheduler

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:1001
+  insertPass(&MachineSchedulerID, &SIWholeQuadModeID);
+  insertPass(&SIWholeQuadModeID, &SIPreAllocateWWMRegsID, false);
+
----------------
Why set VerifyAfter = false?

Also, a nit, I think insertPass(&**MachineSchedulerID**, &SIPreAllocateWWMRegsID, false) would be slightly easier to understand, once you know that insertPass(A,B) just appends B to the list of passes to be inserted after A.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88081/new/

https://reviews.llvm.org/D88081