[PATCH] D87905: [AArch64] Fix ldst optimization of non-immediate store offset
weiwei via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 22 01:55:37 PDT 2020
wwei added a comment.
Update test case by using MIR
================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1190
+ // And make sure the store instruction is in 'reg+imm' form as the load
+ // instruction.
if (MI.mayStore() && isMatchingStore(LoadMI, MI) &&
----------------
efriedma wrote:
> Also, maybe fix this comment to clarify what the problem is. The store should be an opcode that can use an immediate operand. The problem is that the "immediate" might actually be the address of a global variable.
fixed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87905/new/
https://reviews.llvm.org/D87905
More information about the llvm-commits
mailing list