[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 19:10:17 PDT 2020


amyk updated this revision to Diff 293313.
amyk added a comment.

Address Nemanja's review comments:

- More specific comments when bitcasting the inputs
- Pull out conditions to bitcast the input, use ternary op depending if the input is 32 or 64-bits
- Create new static function to check if a given type is the same type as a vector element


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83500/new/

https://reviews.llvm.org/D83500

Files:
  clang/include/clang/Basic/BuiltinsPPC.def
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/lib/Headers/altivec.h
  clang/lib/Sema/SemaChecking.cpp
  clang/test/CodeGen/builtins-ppc-p10vector.c
  clang/test/CodeGen/builtins-ppc-vec-ins-error.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83500.293313.patch
Type: text/x-patch
Size: 15797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200922/9fdeb175/attachment.bin>


More information about the llvm-commits mailing list