[PATCH] D87153: [RFC PATCH 1] BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible

Alexei Starovoitov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 18:56:57 PDT 2020


ast added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp:1072
+  //   - insert a call and mark it with NoMerge function attribute.
+  // We use __builtin_bpf_passthrough() call marked with NoMerge approach.
+  // Compared to inline assembly approach, this has less impact on inlining
----------------
why did you remove the whole comment? Only 'NoMerge' part of it is no longer relevant, right?
But the rest is still very helpful to understand the intent or I'm missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87153/new/

https://reviews.llvm.org/D87153



More information about the llvm-commits mailing list