[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

Mon Sep 21 16:07:37 PDT 2020

jhuber6 added a comment.

In D87946#2286406 <https://reviews.llvm.org/D87946#2286406>, @grokos wrote:

> In D87946#2286024 <https://reviews.llvm.org/D87946#2286024>, @jhuber6 wrote:
>
>> Added ident_t structs to additional runtime functions.
>
> Why are we adding the extra parameter to those additional functions? Non-mapper API functions have been deprecated, clang does not emit them anymore...

I wasn't aware they were explicitly deprecated. If we're keeping around old interfaces for backwards compatibility I should also add in the old mapper functions without the `ident_t` pointer and call into the new functions with a nullptr.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87946/new/

https://reviews.llvm.org/D87946