[PATCH] D87723: [dsymutil][DWARFLinker][NFC] Make interface of AddressMap more general.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

What's the scenario where you run the DWARF linker with already-linked binaries?



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:67-68
 
-  /// Checks that there is a relocation against .debug_info
-  /// table between \p StartOffset and \p NextOffset.
-  ///
-  /// This function must be called with offsets in strictly ascending
-  /// order because it never looks back at relocations it already 'went past'.
-  /// \returns true and sets Info.InDebugMap if it is the case.
-  virtual bool hasValidRelocationAt(uint64_t StartOffset, uint64_t EndOffset,
-                                    CompileUnit::DIEInfo &Info) = 0;
+  /// Checks that specified DIE has a DW_AT_Location attribute
+  /// containing references into live code section. This function
+  /// must be called with DIE`s offsets in strictly ascending order.
----------------



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:73-75
+  /// Checks that specified DIE has a DW_AT_Low_pc attribute
+  /// references into live code section. This function
+  /// must be called with DIE`s offsets in strictly ascending order.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87723/new/

https://reviews.llvm.org/D87723