[PATCH] D87813: [llvm]Add an option to emit cold clusters to a different section.

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 14:55:01 PDT 2020


tmsriram added a comment.

This LGTM after I understood the rationale:

1. It allows fine-grained control of cold split part placement for spatial locality and either mapping to or excluding from huge pages.  This becomes very relevant as we play with the coldness thresholds where  lukewarm parts could be split from hot function bodies.  For these reasons, reusing an existing prefix is not ideal.
2. There is a precedent with ".text.unknown" which has similar motivations.  The lld patch for this is also rather simple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87813/new/

https://reviews.llvm.org/D87813



More information about the llvm-commits mailing list